Enable C++ deptrace when using autobuild build mode - #2160
Merged
henrymercer merged 1 commit intoFeb 22, 2024
Merged
henrymercer merged 1 commit into
henrymercer merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aeisenberg
approved these changes
Feb 22, 2024
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Yep. This looks fine.
Sorry, something went wrong.
Comment thread
src/analyze.ts
This was referenced Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with the experimental internal-only build mode functionality where we wouldn't enable deptrace when extracting C++ using database trace-command. Risk is low since this functionality is guarded behind the internal-only build-mode input.
Merge / deployment checklist