Use the --sarif-include-query-help option when supported - #2191
Merged
henrymercer merged 1 commit intoMar 11, 2024
Merged
henrymercer merged 1 commit into
henrymercer merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aeisenberg
approved these changes
Mar 11, 2024
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM with a minor suggestion.
Sorry, something went wrong.
Comment thread
src/codeql.ts
|
|
||
| async function getCodeScanningQueryHelpArguments( | ||
| codeql: CodeQL, | ||
| ): Promise<string[]> { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Minor: This can return Promise<string> and the use above can remove the ....
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
That's true, but there's also something to be said for having these helper functions consistently return string[] 🤔 I think I'll leave as is.
Sorry, something went wrong.
This was referenced Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids a deprecation warning appearing in the logs.
Merge / deployment checklist