improve logging coverage during sarif upload - #2221
Merged
nickfyson merged 7 commits intoApr 4, 2024
Merged
nickfyson merged 7 commits into
nickfyson merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
nickfyson
force-pushed
the
nickfyson/upload-logging
branch
from
fccba0a to
6514cbb
Compare
April 3, 2024 14:45
nickfyson
marked this pull request as ready for review
April 3, 2024 14:45
nickfyson
marked this pull request as draft
April 3, 2024 14:47
nickfyson
marked this pull request as ready for review
April 3, 2024 15:40
henrymercer
reviewed
Apr 3, 2024
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks! A couple of suggestions:
Sorry, something went wrong.
Comment thread
src/fingerprints.ts
Outdated
Comment thread
src/upload-lib.ts
Outdated
Comment thread
src/upload-lib.ts
Outdated
Comment thread
src/upload-lib.ts
Outdated
Comment thread
src/upload-lib.ts
Outdated
Co-authored-by: Henry Mercer <henrymercer@github.com>
nickfyson
force-pushed
the
nickfyson/upload-logging
branch
from
4b4826a to
2cc8bbd
Compare
April 3, 2024 19:42
angelapwen
approved these changes
Apr 4, 2024
This was referenced Apr 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the coverage of logging when uploading SARIF files, in order to help catch where stalled action runs have encountered problems.
I've mostly added the log lines as info since this didn't seem excessively noisy, except for a few where the level is debug.
Does this seem a reasonable balance...? 🤷♂️
Merge / deployment checklist