FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Run integration test PR checks nightly by angelapwen · Pull Request #2222 · github/codeql-action · GitHub

/ codeql-action Public

Run integration test PR checks nightly - #2222

Merged
angelapwen merged 2 commits into
mainfrom
angelapwen/run-checks-nightly
Apr 4, 2024
ConversationCommits (2)ChecksFiles changed
Merged

Run integration test PR checks nightly#2222
angelapwen merged 2 commits into
mainfrom
angelapwen/run-checks-nightly

Conversation

angelapwen commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

Scheduled for 5AM UTC. This will assist in catching bugs introduced with new runner images.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

aeisenberg previously approved these changes Apr 3, 2024
View reviewed changes

aeisenberg commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

Oops. Still in draft. Code looks good. Let's if everything passes.

angelapwen commented Apr 3, 2024

Copy link
Copy Markdown
Contributor Author

Oops. Still in draft. Code looks good. Let's if everything passes.

I still haven't configured a notification to our team if any of these fail (see backlinked issue). I can do that in a follow-up if we want to start running immediately though.

angelapwen marked this pull request as ready for review April 3, 2024 19:10
angelapwen requested a review from a team as a code owner April 3, 2024 19:10
angelapwen enabled auto-merge April 3, 2024 19:10
angelapwen disabled auto-merge April 3, 2024 19:46

angelapwen commented Apr 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Huh... workflow files don't seem to be working with an error message:

Invalid type for `on`

I'll look into it but nothing comes top of mind as schedule is supported (and we use it elsewhere!)

EDIT: I think I see the syntax error, will fix

angelapwen force-pushed the angelapwen/run-checks-nightly branch 2 times, most recently from f4013bf to 1932e6e Compare April 3, 2024 20:03
Run integration test PR checks nightly
9a9987f 
Scheduled for 5AM UTC. This will assist in catching bugs introduced with new runner images.
angelapwen force-pushed the angelapwen/run-checks-nightly branch from 1932e6e to 9a9987f Compare April 3, 2024 20:04
Specify generated YAML indentations
fb2a9f9 
For consistency with our non-autogenerated files and GitHub documentation, we should further indent items in lists (`sequence`).

angelapwen commented Apr 3, 2024

Copy link
Copy Markdown
Contributor Author

PR check failures are now due to upstream (usually transient) setup-swift failures.

aeisenberg approved these changes Apr 3, 2024
View reviewed changes

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks reasonable. If the failures are transient, I'll leave it up to you if you want to override the failures and merge or re-run later.

angelapwen commented Apr 3, 2024

Copy link
Copy Markdown
Contributor Author

I don't think we have a way to force green on this repo, and I'd rather not make all those checks non-required (and then make them required again later), so I'll wait to re-run.

angelapwen merged commit f421cda into main Apr 4, 2024
angelapwen deleted the angelapwen/run-checks-nightly branch April 4, 2024 17:30
This was referenced Apr 5, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aeisenberg aeisenberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL