Remove support for CodeQL 2.12.5 and earlier - #2232
Merged
henrymercer merged 7 commits intoApr 9, 2024
Merged
henrymercer merged 7 commits into
henrymercer merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
angelapwen
previously approved these changes
Apr 9, 2024
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🧹 just one comment!!
Sorry, something went wrong.
Comment thread
pr-checks/sync.py
| 'name': 'Set environment variable for Swift enablement', | ||
| 'if': "runner.os != 'Windows' && matrix.version == '20221211'", | ||
| 'shell': 'bash', | ||
| 'run': 'echo "CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT=true" >> $GITHUB_ENV' |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I think we can remove this conditional too:
(requires a rebuild 🙇)
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Yes, agreed!
Sorry, something went wrong.
angelapwen
approved these changes
Apr 9, 2024
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good to me!
Sorry, something went wrong.
This was referenced Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #2220 where we announced that support for CodeQL v2.12.5 and earlier would be removed after these versions were deprecated alongside GHES 3.8.
We'll need to update the set of required PR checks before merging this.
Merge / deployment checklist