Fail more clearly if the file program is not installed on the runner - #2234
Merged
mbg merged 10 commits intoApr 15, 2024
Merged
mbg merged 10 commits into
mbg merged 10 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mbg
force-pushed
the
mbg/clearer-file-command-failure
branch
from
9f15e90 to
cc356e1
Compare
April 11, 2024 13:19
mbg
force-pushed
the
mbg/clearer-file-command-failure
branch
from
944c14e to
4b0172d
Compare
April 11, 2024 16:21
mbg
marked this pull request as ready for review
April 11, 2024 16:21
henrymercer
reviewed
Apr 11, 2024
Comment thread
src/actions-util.ts
Outdated
Comment thread
src/diagnostics.ts
Comment thread
src/init-action.ts
Outdated
henrymercer
previously approved these changes
Apr 12, 2024
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Very nice, I expect the functionality for writing diagnostics before the database has been initialized will come in handy elsewhere too.
You might want to consider adding a changelog note, otherwise LGTM!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Added a changelog entry |
Sorry, something went wrong.
mbg
enabled auto-merge
April 12, 2024 20:43
auto-merge was automatically disabled
April 12, 2024 20:46
Pull Request is not mergeable
henrymercer
approved these changes
Apr 15, 2024
This was referenced Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR checks more clearly whether we can successfully find the location of the file program and emits a clearer message in the build log as well as a warning-level diagnostic if it cannot be found. There is also a new integration test which checks that this works as intended.
Since the check for whether the Go workaround is needed takes place before the database gets initialised, this PR also modifies the code for diagnostics to:
Merge / deployment checklist