Add some more configuration errors - #2237
henrymercer merged 2 commits into
Conversation
Sorry, something went wrong.
| export function wrapApiConfigurationError(e: unknown) { | ||
| if (isHTTPError(e)) { | ||
| if ( | ||
| e.message.includes("API rate limit exceeded for site ID installation") || |
There was a problem hiding this comment.
My only concern with this one is that we have a bug in the action where we are inadvertently causing rate limits for the repository. I feel like this has happened in the past.
Is this error for an org/user or is it specific to the repository/
Sorry, something went wrong.
There was a problem hiding this comment.
Most of the time the rate limit hits are legitimate, so this creates a level of noise that means we have a bunch of false positive monitor pings or have to raise our thresholds and miss genuine failures. My recommendation is we avoid the possibility of a bug in the Action as part of our monitoring for significant changes in configuration errors, which is intended to capture these errors that are noisy, but have signal in large numbers.
Sorry, something went wrong.
Add configuration errors for:
Merge / deployment checklist