FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add a compatibility table to the README by aeisenberg · Pull Request #2273 · github/codeql-action · GitHub

/ codeql-action Public

Add a compatibility table to the README - #2273

Merged
aeisenberg merged 4 commits into
mainfrom
aeisenberg/specify-versions
May 9, 2024
ConversationCommits (4)ChecksFiles changed
Merged

Add a compatibility table to the README#2273
aeisenberg merged 4 commits into
mainfrom
aeisenberg/specify-versions

Conversation

aeisenberg commented May 6, 2024

Copy link
Copy Markdown
Contributor

Specifies the versions of the action, CLI and GHES that are jointly compatible.

When reviewing, please make sure this is table is clear to read and easy to maintain as we release new versions of the action.

Merge / deployment checklist

  • [n/a] Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • [n/a] Confirm the changelog has been updated if necessary.

aeisenberg requested a review from a team as a code owner May 6, 2024 21:39
aeisenberg force-pushed the aeisenberg/specify-versions branch from 86af32d to 37ba75b Compare May 7, 2024 15:06
henrymercer reviewed May 7, 2024
View reviewed changes

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, this will help clear up something that has created confusion.

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
aeisenberg force-pushed the aeisenberg/specify-versions branch from 37ba75b to 92c7c0d Compare May 7, 2024 20:31
Add a compatibility table to the README
e50fb8f 
Specifies the versions of the action, CLI and GHES that are jointly compatible.
aeisenberg force-pushed the aeisenberg/specify-versions branch from 92c7c0d to e50fb8f Compare May 7, 2024 20:58
henrymercer reviewed May 8, 2024
View reviewed changes
Comment thread README.md Outdated
aeisenberg and others added 2 commits May 8, 2024 11:44

aeisenberg commented May 8, 2024

Copy link
Copy Markdown
Contributor Author

Oops. I just merged a previous PR that put the changelog note in the wrong place. Let me fix that.

aeisenberg requested a review from henrymercer May 8, 2024 19:20
henrymercer reviewed May 8, 2024
View reviewed changes

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It looks like there was a merge in the changelog file that didn't go entirely right, otherwise LGTM.

aeisenberg commented May 8, 2024

Copy link
Copy Markdown
Contributor Author

I think that was already fixed in d234275, unless there's something I missed.

henrymercer commented May 9, 2024

Copy link
Copy Markdown
Contributor

Oh I see, the merge conflict was actually on main.

henrymercer approved these changes May 9, 2024
View reviewed changes

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

aeisenberg merged commit def4d2c into main May 9, 2024
aeisenberg deleted the aeisenberg/specify-versions branch May 9, 2024 15:13
github-actions Bot mentioned this pull request May 13, 2024
Merged
8 tasks
henrymercer mentioned this pull request May 13, 2024
Merged
8 tasks
coderabbitai Bot mentioned this pull request Sep 16, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

henrymercer henrymercer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL