Add support for on-demand feature flags - #2280
Merged
henrymercer merged 5 commits intoMay 10, 2024
Merged
henrymercer merged 5 commits into
henrymercer merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This prevents them from being truncated.
henrymercer
force-pushed
the
henrymercer/on-demand-ffs
branch
from
392a9f9 to
cf4c3b4
Compare
May 9, 2024 13:14
angelapwen
previously approved these changes
May 9, 2024
angelapwen
approved these changes
May 10, 2024
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Sorry, something went wrong.
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for adding a new feature flag to the CodeQL Action without needing to make a corresponding change to an internal codebase.
Specifically, new features can be specified in a features query parameter delivered to the feature flags API.
While we're here, we also log feature flags on separate lines to avoid feature enablement being truncated.
Merge / deployment checklist