FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Disable `fail-fast` for PR checks by henrymercer · Pull Request #2283 · github/codeql-action · GitHub

Disable fail-fast for PR checks - #2283

Merged
henrymercer merged 2 commits into
mainfrom
henrymercer/disable-fail-fast
May 10, 2024
Merged

henrymercer merged 2 commits into
mainfrom
henrymercer/disable-fail-fast

Conversation

henrymercer commented May 10, 2024
edited
Loading

Copy link
Copy Markdown
Contributor

We have found fail-fast has been getting in the way more than it's been helping recently. For example:

  • Sometimes only a particular set of versions or OSes are broken, and we want to let the other checks complete so we can know the full set.
  • We see quite a large degree of parallelism when running the checks, so most of the jobs have nearly finished anyway when they are cancelled by fail-fast.
  • fail-fast deals better with transient failures.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

henrymercer requested a review from a team as a code owner May 10, 2024 15:34

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

henrymercer merged commit a8c32fd into main May 10, 2024
henrymercer deleted the henrymercer/disable-fail-fast branch May 10, 2024 16:28
github-actions Bot mentioned this pull request May 13, 2024
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL