Classify config file and out of disk CLI errors as config errors - #2297
Merged
angelapwen merged 2 commits intoMay 20, 2024
Merged
angelapwen merged 2 commits into
angelapwen merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
There are some CI failures due to a new runner image rollout: it will be fixed as of CLI v2.17.3, which will be released shortly, so this PR is probably blocked from merging until then. |
Sorry, something went wrong.
henrymercer
approved these changes
May 16, 2024
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice!
Sorry, something went wrong.
NlightNFotis
approved these changes
May 16, 2024
This was referenced May 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR classifies CLI errors with "out of disk" and "No space left on device" errors as configuration errors, and appends a link to https://gh.io/troubleshooting-code-scanning/out-of-disk-or-memory to the error.
It also classifies CLI errors related to invalid configuration files as configuration errors.
Merge / deployment checklist