PR Checks: disable tests for Swift on Linux until CLI 2.17.4 - #2299
Merged
henrymercer merged 5 commits intoMay 20, 2024
Merged
henrymercer merged 5 commits into
henrymercer merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Now that this check is running on MacOS, it runs into a known issue with the build tracer on ARM Macs that was fixed in CLI v2.15.1.
Go has been removed from the PATH in the most recent Mac runner images rollouts.
angelapwen
force-pushed
the
angelapwen/fix-pr-checks
branch
from
4fe1a30 to
23c1981
Compare
May 17, 2024 22:33
Looks like there was a bug in the oldest two CLI versions, on `macos-12` here.
angelapwen
marked this pull request as ready for review
May 17, 2024 23:24
henrymercer
approved these changes
May 20, 2024
This was referenced May 31, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the new Linux runner image rollout and CLI versions <= 2.17.3, all PR checks with Swift are failing. This PR disables those tests to unblock CI for now. When CLI version 2.17.4 makes it to nightly-latest and latest, we will re-enable these tests.
The failing PR checks that were previously running on both ubuntu and macos have been updated to only run on macos for now. The failing PR checks that were previously running on only ubuntu have also been updated to only run on macos for now, so that we are at least covering these checks on one operating system.
Now that the debug artifacts check runs on macos instead of ubuntu, old versions of the CLI <2.15.1 are experiencing the known build tracer bug on ARM Macs, so those are disabled for now as well. We programmatically disabled those for the generated PR checks in #2261.
Merge / deployment checklist