Add steady_state_default_setup as field to base status report - #2305
Merged
angelapwen merged 1 commit intoMay 22, 2024
Merged
angelapwen merged 1 commit into
angelapwen merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
angelapwen
marked this pull request as ready for review
May 22, 2024 20:28
This will help us distinguish steady-state runs in default setup mode from advanced setup runs and default setup validation/onboarding runs.
angelapwen
force-pushed
the
angelapwen/add-steady-state-status-report
branch
from
a1abd0d to
4f7eb81
Compare
May 22, 2024 20:39
aeisenberg
reviewed
May 22, 2024
Comment thread
src/status-report.ts
| core.exportVariable(EnvVar.TESTING_ENVIRONMENT, testingEnvironment); | ||
| } | ||
| const isSteadyStateDefaultSetupRun = | ||
| process.env["CODE_SCANNING_IS_STEADY_STATE_DEFAULT_SETUP"] === "true"; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Presumably, this env var is set in the dynamic workflow when appropriate?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Yes! I will tag you on the internal PR for it 😄
Sorry, something went wrong.
aeisenberg
approved these changes
May 22, 2024
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM! Assuming the answer to my question is "yes".
Sorry, something went wrong.
This was referenced May 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help us distinguish steady-state runs in default setup mode from advanced setup runs and default setup validation/onboarding runs.
The environment variable will be set accordingly in code scanning.
Merge / deployment checklist