FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

PR Checks: Use `tools: linked` rather than `tools: latest` by angelapwen · Pull Request #2320 · github/codeql-action · GitHub

/ codeql-action Public

PR Checks: Use tools: linked rather than tools: latest - #2320

Merged
angelapwen merged 1 commit into
mainfrom
angelapwen/use-linked-in-tests
May 31, 2024
ConversationCommits (1)ChecksFiles changed
Merged

PR Checks: Use tools: linked rather than tools: latest#2320
angelapwen merged 1 commit into
mainfrom
angelapwen/use-linked-in-tests

Conversation

angelapwen commented May 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

As of #2281, we introduced linked as a more descriptive value for the tools input. This PR updates our own PR checks and workflows with the new value and changes the input/output in the prepare-test Action to use linked.

All of the required PR checks that had latest in their names, for main have been updated. As we release v3 and v2 we'll want to do the same for those branches.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

PR Checks: Use tools: linked rather than tools: latest
67d5a9a 
Also changes the input and output in the `prepare-test` Action to use `linked`.
angelapwen force-pushed the angelapwen/use-linked-in-tests branch from 2d5d2ad to 67d5a9a Compare May 31, 2024 09:49

github-advanced-security AI commented May 31, 2024

Copy link
Copy Markdown
Contributor

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

angelapwen force-pushed the angelapwen/use-linked-in-tests branch from 3b0d213 to 67d5a9a Compare May 31, 2024 10:02
angelapwen marked this pull request as ready for review May 31, 2024 11:40
angelapwen requested a review from a team as a code owner May 31, 2024 11:40
angelapwen requested a review from NlightNFotis May 31, 2024 11:40

henrymercer commented May 31, 2024

Copy link
Copy Markdown
Contributor

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

I think this is happening because we renamed tools: latest to tools: linked. Once we've merged this PR we can go through to the tool status page and delete the analysis for tools: latest to avoid a stale tip.

NlightNFotis approved these changes May 31, 2024
View reviewed changes

NlightNFotis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks comprehensive to me, thank you for your effort cleaning this up.

I have a couple of questions (minor, so not to hold up this PR from getting merged):

  • Is there any way for us to know if we have forgotten any places where this should be sustituted, save for doing a whole source-root grep?
  • If we have forgotten anything, my understanding is that the impact is going to be low, given the intentional backwards compatibility in the change. Is this still deemed accurate, or am I missing something that requires greater precision in the change?

angelapwen commented May 31, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the review!!

  • Is there any way for us to know if we have forgotten any places where this should be sustituted, save for doing a whole source-root grep?

I also just greped it 🤔 I don't know that there's a better way, but (as you mentioned) the impact is low so I think it's fine if we end up with some extra latest workflows.

  • If we have forgotten anything, my understanding is that the impact is going to be low, given the intentional backwards compatibility in the change. Is this still deemed accurate, or am I missing something that requires greater precision in the change?

That's still accurate! I just saw the warnings when I was checking the logs of some PR checks and thought it would be best to switch over. The linked naming really clarifies the intent, I think!

angelapwen merged commit add199b into main May 31, 2024
angelapwen deleted the angelapwen/use-linked-in-tests branch May 31, 2024 13:55
This was referenced Jun 4, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

NlightNFotis NlightNFotis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL