Fix incompatibility between direct tracing in the autobuild Action and specifying a custom working directory - #2328
Merged
henrymercer merged 8 commits intoJun 13, 2024
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
To avoid re-enabling the flag for old Action versions.
aeisenberg
reviewed
Jun 11, 2024
aeisenberg
previously approved these changes
Jun 11, 2024
Comment thread
src/database-upload.ts
We are already testing the analyze Action in a separate check.
Just call `analyze`, since `upload: never` skips most of the functionality we want to test anyway.
aeisenberg
approved these changes
Jun 12, 2024
This was referenced Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the AutobuildDirectTracing feature where it would ignore the working-directory input to the autobuild Action. The fix is to pass Node's working directory to the CLI, since we already change directory in Node based on the input. We also bump the version of the feature flag so that we can avoid re-enabling the flag for old Action versions.
I've added a PR check to validate that the fix works.
Merge / deployment checklist