Avoid failing when debug artifacts can't be uploaded - #2349
Merged
aeisenberg merged 2 commits intoJun 22, 2024
Merged
aeisenberg merged 2 commits into
aeisenberg merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Failing to upload debug artifacts should not fail the action since it is possible that the action has already succeeded by the time this failure occurs.
aeisenberg
force-pushed
the
aeisenberg/no-fail-upload-artifacts
branch
from
24e7d63 to
9507482
Compare
June 20, 2024 19:06
angelapwen
previously approved these changes
Jun 21, 2024
Copy link
Copy Markdown
Contributor
|
Maybe we should add a note in the changelog about this change? 💭 |
Sorry, something went wrong.
NlightNFotis
previously approved these changes
Jun 21, 2024
NlightNFotis
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Yep, a warning for this is good behaviour IMO.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Yes. We should. I meant too....but forgot. |
Sorry, something went wrong.
aeisenberg
enabled auto-merge
June 21, 2024 18:50
auto-merge was automatically disabled
June 21, 2024 18:53
Pull Request is not mergeable
angelapwen
approved these changes
Jun 22, 2024
This was referenced Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failing to upload debug artifacts should not fail the action since it is possible that the action has already succeeded by the time this failure occurs.
Merge / deployment checklist