FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add codeql-version to outputs by mschwager · Pull Request #2368 · github/codeql-action · GitHub

/ codeql-action Public

Add codeql-version to outputs - #2368

Merged
aeisenberg merged 4 commits into
github:mainfrom
mschwager:add-codeql-version
Jul 12, 2024
ConversationCommits (4)ChecksFiles changed
Merged

Add codeql-version to outputs#2368
aeisenberg merged 4 commits into
github:mainfrom
mschwager:add-codeql-version

Conversation

mschwager commented Jul 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #2367.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

Regarding the CHANGELOG check above, my understanding was that this would be automatically populated on release?

mschwager requested a review from a team as a code owner July 10, 2024 16:02
aeisenberg changed the title Fix #2367, add codeql-version to outputs Add codeql-version to outputs Jul 10, 2024

aeisenberg commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

Thanks for your PR! The changelog note for this PR needs to be added manually. The automation for the changelog is around adding the release version number and the date.

mschwager commented Jul 10, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for your PR! The changelog note for this PR needs to be added manually. The automation for the changelog is around adding the release version number and the date.

Done!

aeisenberg reviewed Jul 10, 2024
View reviewed changes
Comment thread CHANGELOG.md Outdated
aeisenberg previously approved these changes Jul 10, 2024
View reviewed changes

mschwager commented Jul 12, 2024

Copy link
Copy Markdown
Contributor Author

Hey @ginsbach or @aeisenberg, would you mind approving the CI workflows to unblock merging?

mschwager requested a review from aeisenberg July 12, 2024 15:22

mschwager commented Jul 12, 2024

Copy link
Copy Markdown
Contributor Author

Looks like it needs re-approval after the merge too

aeisenberg commented Jul 12, 2024

Copy link
Copy Markdown
Contributor

Thanks for the reminder. And thanks for your contribution!

aeisenberg merged commit 09653b7 into github:main Jul 12, 2024
henrymercer mentioned this pull request Jul 12, 2024
Merged
3 tasks
mschwager deleted the add-codeql-version branch July 12, 2024 17:32

mschwager commented Jul 12, 2024

Copy link
Copy Markdown
Contributor Author

Sure thing, thanks for the speedy reviews!

This was referenced Jul 18, 2024
Closed
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aeisenberg aeisenberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add CodeQL version to github/codeql-action/init outputs

2 participants

Back | FazBrowse Home | New Git URL