Classify autobuild errors as configuration errors - #2382
Merged
angelapwen merged 1 commit intoJul 22, 2024
Merged
angelapwen merged 1 commit into
angelapwen merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
angelapwen
force-pushed
the
angelapwen/make-autobuild-config-error
branch
from
b880664 to
b516521
Compare
July 22, 2024 12:36
angelapwen
marked this pull request as ready for review
July 22, 2024 12:40
henrymercer
approved these changes
Jul 22, 2024
This was referenced Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change converts all CLI errors related to autobuild to configuration errors, so that they do not affect our SLOs or monitors.
We actually already extract autobuild errors from the stderr of the CLI output and prepend the We were unable to automatically build your code text, so it's straightforward to match on this error message and classify it as a configuration error.
Merge / deployment checklist