Fix writing diagnostics on Windows - #2430
Merged
henrymercer merged 2 commits intoAug 19, 2024
Merged
henrymercer merged 2 commits into
henrymercer merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Remove colons from the generated filename so it is valid on Windows.
nickfyson
previously approved these changes
Aug 19, 2024
nickfyson
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
nickfyson
approved these changes
Aug 19, 2024
Copy link
Copy Markdown
Contributor
Author
|
Checked that the diagnostics are being written correctly in the PR checks. We may want to add an automated test too, but I'm not sure it's worth it. |
Sorry, something went wrong.
This was referenced Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue where the CodeQL Action could not write diagnostics on Windows by removing colons from the generated filename so it is valid on Windows.
Merge / deployment checklist