FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Upload sarif for eslint results by aeisenberg · Pull Request #2469 · github/codeql-action · GitHub

/ codeql-action Public

Upload sarif for eslint results - #2469

Merged
aeisenberg merged 3 commits into
mainfrom
aeisenberg/upload-eslint-sarif
Sep 10, 2024
ConversationCommits (3)ChecksFiles changed
Merged

Upload sarif for eslint results#2469
aeisenberg merged 3 commits into
mainfrom
aeisenberg/upload-eslint-sarif

Conversation

aeisenberg commented Sep 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This change will upload the eslint results as sarif to code scanning during the CI process.

Merge / deployment checklist

  • [n/a] Confirm this change is backwards compatible with existing workflows.
  • [n/a] Confirm the readme has been updated if necessary.
  • [n/a] Confirm the changelog has been updated if necessary.

aeisenberg requested a review from a team as a code owner September 9, 2024 20:16

github-advanced-security AI commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

aeisenberg force-pushed the aeisenberg/upload-eslint-sarif branch from 1d6d169 to 55c72b9 Compare September 9, 2024 20:21

aeisenberg commented Sep 9, 2024

Copy link
Copy Markdown
Contributor Author

It's surprising to me that code scanning is showing a bunch of alerts even though when run locally, they don't appear.

https://github.com/github/codeql-action/security/code-scanning?query=pr%3A2469+is%3Aopen

It looks like the sarif formatter is including alerts that are disabled by eslint-disable-next-line.

aeisenberg force-pushed the aeisenberg/upload-eslint-sarif branch from 1c1e8ae to 0d3665a Compare September 9, 2024 23:41
rvermeulen previously approved these changes Sep 10, 2024
View reviewed changes

rvermeulen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me. Once the test are passing we are good to

aeisenberg force-pushed the aeisenberg/upload-eslint-sarif branch from 0d3665a to 56b8418 Compare September 10, 2024 22:31
aeisenberg merged commit e817992 into main Sep 10, 2024
aeisenberg deleted the aeisenberg/upload-eslint-sarif branch September 10, 2024 22:51
github-actions Bot mentioned this pull request Sep 13, 2024
Merged
8 tasks
dbartol mentioned this pull request Sep 13, 2024
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
rvermeulen rvermeulen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL