Always upload eslint.sarif - #2474
Merged
aeisenberg merged 1 commit intoSep 12, 2024
Merged
aeisenberg merged 1 commit into
aeisenberg merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
src/status-report.ts
Fixed
Comment thread
src/status-report.ts
Fixed
Comment thread
src/status-report.ts
Fixed
Comment thread
src/status-report.ts
Fixed
aeisenberg
force-pushed
the
aeisenberg/always-upload-eslint-sarif
branch
from
908133d to
0d0f998
Compare
September 10, 2024 23:09
aeisenberg
marked this pull request as ready for review
September 10, 2024 23:10
Copy link
Copy Markdown
Contributor
Author
|
@rvermeulen, can I get another review? |
Sorry, something went wrong.
aeisenberg
enabled auto-merge
September 11, 2024 21:20
angelapwen
approved these changes
Sep 12, 2024
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This means that it will always upload even if previous steps fail, right? 👍
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Yes. Here's an example of this working: #2473 Oh...I see now that the only alerts left are ones where autofix didn't generate a fix. But please trust me that it worked. |
Sorry, something went wrong.
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist