Use generated token on checkout - #2481
Merged
dbartol merged 1 commit intoSep 13, 2024
Merged
dbartol merged 1 commit into
dbartol merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The script `.github/update-release-branch.py` uses the `git` command to push changes. Therefore we need to ensure that `git` authenticates with a token that has the `workflows` write permision. This change restore the GitHub token used by the script to access the API and applies the `workflows` write permission to the token used by `git`.
Copy link
Copy Markdown
|
Where does the workflows: write permission get applied? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
The GitHub App generating the token applies that permission. The token is then used by by git to push. |
Sorry, something went wrong.
dbartol
approved these changes
Sep 13, 2024
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script .github/update-release-branch.py uses the git command to push changes. Therefore we need to ensure that git authenticates with a token that has the workflows write permision.
This change restore the GitHub token used by the script to access the API and applies the workflows write permission to the token used by git.
Merge / deployment checklist