Avoid uploading eslint sarif for dependabot PR - #2499
Merged
aeisenberg merged 2 commits intoSep 23, 2024
Merged
aeisenberg merged 2 commits into
aeisenberg merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aeisenberg
marked this pull request as ready for review
September 23, 2024 19:11
Dependabot does not have `security-events: write` permission.s
aeisenberg
force-pushed
the
aeisenberg/no-upload-sarif
branch
from
69668d3 to
9580b7e
Compare
September 23, 2024 19:12
angelapwen
previously approved these changes
Sep 23, 2024
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks!!
Sorry, something went wrong.
aeisenberg
commented
Sep 23, 2024
Comment thread
.github/workflows/pr-checks.yml
Outdated
Copy link
Copy Markdown
Contributor
Author
|
Minor change to align with what we're doing for vscode-codeql. Can you re-review? |
Sorry, something went wrong.
angelapwen
approved these changes
Sep 23, 2024
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Makes sense!
Sorry, something went wrong.
This was referenced Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot does not have security-events: write permission.
See #2485