FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bump the npm group with 3 updates by dependabot[bot] · Pull Request #2510 · github/codeql-action · GitHub

/ codeql-action Public

Bump the npm group with 3 updates - #2510

Merged
aeisenberg merged 3 commits into
mainfrom
dependabot/npm_and_yarn/npm-13baf58ce8
Oct 2, 2024
ConversationCommits (3)ChecksFiles changed
Merged

Bump the npm group with 3 updates#2510
aeisenberg merged 3 commits into
mainfrom
dependabot/npm_and_yarn/npm-13baf58ce8

Conversation

dependabot Bot commented on behalf of github Sep 30, 2024

Copy link
Copy Markdown
Contributor

Bumps the npm group with 3 updates: @octokit/types, @eslint/js and eslint-plugin-import.

Updates @octokit/types from 13.5.0 to 13.6.0

Release notes

Sourced from @​octokit/types's releases.

v13.6.0

13.6.0 (2024-09-27)

Features

  • add better types for request.request.signal (#649) (78173c7)

v13.5.1

13.5.1 (2024-09-24)

Bug Fixes

  • deps: update dependency @​octokit/tsconfig to v4 (#610) (b01e2fb)
Commits
  • 78173c7 feat: add better types for request.request.signal (#649)
  • b01e2fb fix(deps): update dependency @​octokit/tsconfig to v4 (#610)
  • c8bb699 build(deps-dev): bump dset from 3.1.3 to 3.1.4 (#648)
  • e52f6e9 chore(deps): update dependency json-schema-to-typescript to v15 (#647)
  • aca1e8b chore(deps): update dependency typedoc to ^0.26.0
  • 9370d29 ci(action): update actions/add-to-project action to v1.0.2 (#646)
  • f92bd84 build(deps-dev): bump braces from 3.0.2 to 3.0.3
  • 3de1385 ci(action): update actions/checkout digest to 692973e (#643)
  • b21cc04 🚧 Workflows have changed (#642)
  • 20bdca2 chore(deps): update dependency semantic-release to v24 (#641)
  • Additional commits viewable in compare view

Updates @eslint/js from 9.11.0 to 9.11.1

Release notes

Sourced from @​eslint/js's releases.

v9.11.1

Bug Fixes

  • 20fd916 fix: add @eslint/core, @types/estree, & @types/json-schema deps (#18938) (Nitin Kumar)
  • 2738322 fix: add missing types for require-atomic-updates rule (#18937) (Kristóf Poduszló)
  • d71ff30 fix: add missing types for object-shorthand rule (#18935) (Kristóf Poduszló)
  • 561cadc fix: add missing types for no-unsafe-negation rule (#18932) (Kristóf Poduszló)
  • 8843656 fix: add missing types for no-underscore-dangle rule (#18931) (Kristóf Poduszló)
  • 92cde5c fix: add missing types for no-shadow rule (#18930) (Kristóf Poduszló)
  • b3cbe11 fix: add missing types for no-sequences rule (#18929) (Kristóf Poduszló)
  • 976f77f fix: add missing types for no-unused-expressions rule (#18933) (Kristóf Poduszló)

Documentation

  • 3eff709 docs: replace deprecated Linter.FlatConfig type with Linter.Config (#18941) (Carlos Meira)

Chores

  • df4a859 chore: upgrade @​eslint/js@​9.11.1 (#18943) (Milos Djermanovic)
  • 36d8095 chore: package.json update for @​eslint/js release (Jenkins)
Changelog

Sourced from @​eslint/js's changelog.

v9.11.1 - September 23, 2024

  • df4a859 chore: upgrade @​eslint/js@​9.11.1 (#18943) (Milos Djermanovic)
  • 36d8095 chore: package.json update for @​eslint/js release (Jenkins)
  • 20fd916 fix: add @eslint/core, @types/estree, & @types/json-schema deps (#18938) (Nitin Kumar)
  • 3eff709 docs: replace deprecated Linter.FlatConfig type with Linter.Config (#18941) (Carlos Meira)
  • 2738322 fix: add missing types for require-atomic-updates rule (#18937) (Kristóf Poduszló)
  • d71ff30 fix: add missing types for object-shorthand rule (#18935) (Kristóf Poduszló)
  • 561cadc fix: add missing types for no-unsafe-negation rule (#18932) (Kristóf Poduszló)
  • 8843656 fix: add missing types for no-underscore-dangle rule (#18931) (Kristóf Poduszló)
  • 92cde5c fix: add missing types for no-shadow rule (#18930) (Kristóf Poduszló)
  • b3cbe11 fix: add missing types for no-sequences rule (#18929) (Kristóf Poduszló)
  • 976f77f fix: add missing types for no-unused-expressions rule (#18933) (Kristóf Poduszló)
Commits

Updates eslint-plugin-import from 2.29.1 to 2.30.0

Release notes

Sourced from eslint-plugin-import's releases.

v2.30.0

Added

Fixed

Changed

  • [Docs] no-extraneous-dependencies: Make glob pattern description more explicit (#2944, thanks [@​mulztob])
  • [no-unused-modules]: add console message to help debug #2866
  • [Refactor] ExportMap: make procedures static instead of monkeypatching exportmap (#2982, thanks [@​soryy708])
  • [Refactor] ExportMap: separate ExportMap instance from its builder logic (#2985, thanks [@​soryy708])
  • [Docs] order: Add a quick note on how unbound imports and --fix (#2640, thanks [@​minervabot])
  • [Tests] appveyor -> GHA (run tests on Windows in both pwsh and WSL + Ubuntu) (#2987, thanks [@​joeyguerra])
  • [actions] migrate OSX tests to GHA ([ljharb#37], thanks [@​aks-])
  • [Refactor] exportMapBuilder: avoid hoisting (#2989, thanks [@​soryy708])
  • [Refactor] ExportMap: extract "builder" logic to separate files (#2991, thanks [@​soryy708])
  • [Docs] [order]: update the description of the pathGroupsExcludedImportTypes option (#3036, thanks [@​liby])
  • [readme] Clarify how to install the plugin (#2993, thanks [@​jwbth])

... (truncated)

Changelog

Sourced from eslint-plugin-import's changelog.

[2.30.0] - 2024-09-02

Added

  • [dynamic-import-chunkname]: add allowEmpty option to allow empty leading comments (#2942, thanks [@​JiangWeixian])
  • [dynamic-import-chunkname]: Allow empty chunk name when webpackMode: 'eager' is set; add suggestions to remove name in eager mode (#3004, thanks [@​amsardesai])
  • [no-unused-modules]: Add ignoreUnusedTypeExports option (#3011, thanks [@​silverwind])
  • add support for Flat Config (#3018, thanks [@​michaelfaith])

Fixed

Changed

  • [Docs] no-extraneous-dependencies: Make glob pattern description more explicit (#2944, thanks [@​mulztob])
  • [no-unused-modules]: add console message to help debug #2866
  • [Refactor] ExportMap: make procedures static instead of monkeypatching exportmap (#2982, thanks [@​soryy708])
  • [Refactor] ExportMap: separate ExportMap instance from its builder logic (#2985, thanks [@​soryy708])
  • [Docs] order: Add a quick note on how unbound imports and --fix (#2640, thanks [@​minervabot])
  • [Tests] appveyor -> GHA (run tests on Windows in both pwsh and WSL + Ubuntu) (#2987, thanks [@​joeyguerra])
  • [actions] migrate OSX tests to GHA ([ljharb#37], thanks [@​aks-])
  • [Refactor] exportMapBuilder: avoid hoisting (#2989, thanks [@​soryy708])
  • [Refactor] ExportMap: extract "builder" logic to separate files (#2991, thanks [@​soryy708])
  • [Docs] [order]: update the description of the pathGroupsExcludedImportTypes option (#3036, thanks [@​liby])
  • [readme] Clarify how to install the plugin (#2993, thanks [@​jwbth])
Commits
  • 18787d3 Bump to 2.30.0
  • 9902298 [Deps] update eslint-module-utils
  • 9d194a6 [utils] v2.9.0
  • 0a58d75 [resolvers/webpack] v0.13.9
  • a3015eb [Test] namespace: ensure valid case is actually included
  • 8bdb32b [Test] add explicit marker for trailing whitespace in cases
  • 038c26c [readme] Clarify how to install the plugin
  • 32a2b89 [Fix] order: do not compare first path segment for relative paths (#2682)
  • ee1ea02 [Fix] newline-after-import: fix considerComments option when require
  • 806e3c2 [New] add support for Flat Config
  • Additional commits viewable in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
@octokit/types [< 7, > 6.21.1]

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bump the npm group with 3 updates
3fe5410 
Bumps the npm group with 3 updates: [@octokit/types](https://github.com/octokit/types.ts), [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js) and [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import).


Updates `@octokit/types` from 13.5.0 to 13.6.0
- [Release notes](https://github.com/octokit/types.ts/releases)
- [Commits](octokit/types.ts@v13.5.0...v13.6.0)

Updates `@eslint/js` from 9.11.0 to 9.11.1
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/commits/v9.11.1/packages/js)

Updates `eslint-plugin-import` from 2.29.1 to 2.30.0
- [Release notes](https://github.com/import-js/eslint-plugin-import/releases)
- [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md)
- [Commits](import-js/eslint-plugin-import@v2.29.1...v2.30.0)

---
updated-dependencies:
- dependency-name: "@octokit/types"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: npm
- dependency-name: "@eslint/js"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: npm
- dependency-name: eslint-plugin-import
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm
...

Signed-off-by: dependabot[bot] <support@github.com>
dependabot Bot added the Update dependencies Trigger PR workflow to update dependencies label Sep 30, 2024
dependabot Bot requested a review from a team as a code owner September 30, 2024 17:12
dependabot Bot requested a review from a team September 30, 2024 17:12
github-actions Bot removed the Update dependencies Trigger PR workflow to update dependencies label Sep 30, 2024

github-actions Bot commented Sep 30, 2024

Copy link
Copy Markdown
Contributor

Pushed a commit to update the checked-in dependencies. Please mark the PR as ready for review to trigger PR checks.

github-actions Bot marked this pull request as draft September 30, 2024 17:13
aeisenberg added the Update dependencies Trigger PR workflow to update dependencies label Sep 30, 2024
aeisenberg marked this pull request as ready for review September 30, 2024 17:27
github-actions Bot removed the Update dependencies Trigger PR workflow to update dependencies label Sep 30, 2024
aeisenberg previously approved these changes Sep 30, 2024
View reviewed changes

angelapwen commented Sep 30, 2024

Copy link
Copy Markdown
Contributor

We keep running into the linting issue with eslint-import-plugin and we've been manually removing that bump for now: #2484 (comment) but it would be good to investigate why it happens!

aeisenberg commented Oct 1, 2024

Copy link
Copy Markdown
Contributor

Great. 😓 It's working locally and in a codespace.

angelapwen commented Oct 1, 2024

Copy link
Copy Markdown
Contributor

That's odd, in the previous PR linked I'd run it locally and come up with exit code 1:

Run npm run-script lint-ci
  
> codeql@3.26.8 lint-ci
> SARIF_ESLINT_IGNORE_SUPPRESSED=true eslint --report-unused-disable-directives --max-warnings=0 . --format @microsoft/eslint-formatter-sarif --output-file=eslint.sarif

aeisenberg commented Oct 1, 2024

Copy link
Copy Markdown
Contributor

What version of node are you running? I tried on v20.15.1 and v22.9.0.

aeisenberg commented Oct 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Just tried with v21.7.3 and same.

Here's the full output:

 $ npm run-script lint-ci

> codeql@3.26.11 lint-ci
> SARIF_ESLINT_IGNORE_SUPPRESSED=true eslint --report-unused-disable-directives --max-warnings=0 . --format @microsoft/eslint-formatter-sarif --output-file=eslint.sarif

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.6.0

YOUR TYPESCRIPT VERSION: 5.6.2

Please only submit bug reports when using the officially supported version.

=============

aeisenberg commented Oct 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Verified that I am still getting the same behaviour in a codespace (ie- eslint is running, but spitting out a warning), using the same versions of npm and node as is being used in the "PR Checks / Check JS (current)" workflow.

aeisenberg commented Oct 1, 2024

Copy link
Copy Markdown
Contributor

With the help of @angelapwen, we discovered that the command I was executing did indeed fail. Running the eslint command directly, without the eslint sarif formatter printed the errors to the console.

/Users/aeisenberg/git-repos/github/codeql-action/src/analyze.ts
  7:23  error  Parse errors in imported module 'js-yaml': parserPath or languageOptions.parser is required! (undefined:undefined)  import/namespace
  7:23  error  Parse errors in imported module 'js-yaml': parserPath or languageOptions.parser is required! (undefined:undefined)  import/no-deprecated

/Users/aeisenberg/git-repos/github/codeql-action/src/codeql.test.ts
  9:23  error  Parse errors in imported module 'js-yaml': parserPath or languageOptions.parser is required! (undefined:undefined)  import/namespace
  9:23  error  Parse errors in imported module 'js-yaml': parserPath or languageOptions.parser is required! (undefined:undefined)  import/no-deprecated

/Users/aeisenberg/git-repos/github/codeql-action/src/codeql.ts
  6:23  error  Parse errors in imported module 'js-yaml': parserPath or languageOptions.parser is required! (undefined:undefined)  import/namespace
  6:23  error  Parse errors in imported module 'js-yaml': parserPath or languageOptions.parser is required! (undefined:undefined)  import/no-deprecated

/Users/aeisenberg/git-repos/github/codeql-action/src/config-utils.test.ts
  6:23  error  Parse errors in imported module 'js-yaml': parserPath or languageOptions.parser is required! (undefined:undefined)  import/namespace
  6:23  error  Parse errors in imported module 'js-yaml': parserPath or languageOptions.parser is required! (undefined:undefined)  import/no-deprecated

/Users/aeisenberg/git-repos/github/codeql-action/src/config-utils.ts
  5:23  error  Parse errors in imported module 'js-yaml': parserPath or languageOptions.parser is required! (undefined:undefined)  import/namespace
  5:23  error  Parse errors in imported module 'js-yaml': parserPath or languageOptions.parser is required! (undefined:undefined)  import/no-deprecated

/Users/aeisenberg/git-repos/github/codeql-action/src/util.ts
  8:28  error  Parse errors in imported module 'check-disk-space': parserPath or languageOptions.parser is required! (undefined:undefined)  import/namespace
  8:28  error  Parse errors in imported module 'check-disk-space': parserPath or languageOptions.parser is required! (undefined:undefined)  import/no-deprecated
  8:28  error  Parse errors in imported module 'check-disk-space': parserPath or languageOptions.parser is required! (undefined:undefined)  import/default
  8:28  error  Parse errors in imported module 'check-disk-space': parserPath or languageOptions.parser is required! (undefined:undefined)  import/no-named-as-default
  8:28  error  Parse errors in imported module 'check-disk-space': parserPath or languageOptions.parser is required! (undefined:undefined)  import/no-named-as-default-member

/Users/aeisenberg/git-repos/github/codeql-action/src/workflow.test.ts
  2:23  error  Parse errors in imported module 'js-yaml': parserPath or languageOptions.parser is required! (undefined:undefined)  import/namespace
  2:23  error  Parse errors in imported module 'js-yaml': parserPath or languageOptions.parser is required! (undefined:undefined)  import/no-deprecated

/Users/aeisenberg/git-repos/github/codeql-action/src/workflow.ts
  6:23  error  Parse errors in imported module 'js-yaml': parserPath or languageOptions.parser is required! (undefined:undefined)  import/namespace
  6:23  error  Parse errors in imported module 'js-yaml': parserPath or languageOptions.parser is required! (undefined:undefined)  import/no-deprecated

✖ 19 problems (19 errors, 0 warnings)

This means that the 'js-yaml' module is malformed. It might mean updating the eslint config so that parserPath or languageOptions.parser is set properly, but I haven't been able to figure out how to configure these yet.

Undo eslint-plugin-import bump
2f6cf48 
This package must stay at 2.29.1 until a version of the
package is released that supports eslint v9.

aeisenberg commented Oct 2, 2024

Copy link
Copy Markdown
Contributor

OK. It's not worth my spending any more time on this. Until the next version of eslint-plugin-import is released, which supports eslint 9, when we can't upgrade. And even then, we will need our other eslint plugin dependencies to support v9 as well. So, I think we're stuck on eslint-plugin-import@2.29.1 for a while.

aeisenberg enabled auto-merge October 2, 2024 02:21
aeisenberg merged commit c4d433c into main Oct 2, 2024
aeisenberg deleted the dependabot/npm_and_yarn/npm-13baf58ce8 branch October 2, 2024 02:31

angelapwen commented Oct 2, 2024

Copy link
Copy Markdown
Contributor

Should we ignore it dependabot config file and document when we can upgrade it there?

aeisenberg commented Oct 2, 2024

Copy link
Copy Markdown
Contributor

Good idea. I'll take care of that.

aeisenberg added a commit that referenced this pull request Oct 2, 2024
Exclupde eslint-plugin-import updates from dependabot
ecac2c6 
See #2510 for reason why.
aeisenberg mentioned this pull request Oct 2, 2024
Merged
3 tasks
This was referenced Oct 3, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aeisenberg aeisenberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL