FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

PR checks: small fixups to `prepare-action` by angelapwen · Pull Request #2548 · github/codeql-action · GitHub

PR checks: small fixups to prepare-action - #2548

Merged
angelapwen merged 2 commits into
mainfrom
angelapwen/fix-prepare-test
Oct 16, 2024
Merged

angelapwen merged 2 commits into
mainfrom
angelapwen/fix-prepare-test

Conversation

Copy link
Copy Markdown
Contributor

While working on a version of this for testing on runner images, I noticed some improvements to be made:

  • the action now expects stable CLI version inputs as stable-vX.Y.Z rather than with dates. Our current PR checks already use this format but the documentation for the input needed to be updated.
  • the nightly version format also should expect nightly-YYYYMMDD rather than with dashes
  • the nightly bundle URL formatting has been corrected to remove the manual suffix — eg. the current nightly URLs look like: https://github.com/dsp-testing/codeql-cli-nightlies/releases/download/codeql-bundle-20240823/codeql-bundle-linux64.tar.gz. We haven't caught this because none of our PR checks use the dated nightly bundles.
  • when the version is linked or default we return the appropriate tools input early.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

angelapwen force-pushed the angelapwen/fix-prepare-test branch from 9092cbf to 2f0f924 Compare October 15, 2024 23:17
angelapwen marked this pull request as ready for review October 15, 2024 23:28
angelapwen requested a review from a team as a code owner October 15, 2024 23:28
angelapwen merged commit ad94f2f into main Oct 16, 2024
angelapwen deleted the angelapwen/fix-prepare-test branch October 16, 2024 15:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL