Fix name of Python stdlib extraction feature flag - #2550
Merged
henrymercer merged 2 commits intoOct 17, 2024
Merged
henrymercer merged 2 commits into
henrymercer merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
yoff
previously approved these changes
Oct 17, 2024
yoff
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for catching this. I think it is great that you added a test for this also 💪 (If I misunderstood the naming convention, others might too.)
Sorry, something went wrong.
NlightNFotis
previously approved these changes
Oct 17, 2024
yoff
approved these changes
Oct 17, 2024
yoff
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This currently has little effect due to the way the Python extractor interprets environment variables, but it will allow us to make a more standard interpretation in the future. (This is not unlikely, if we start moving to extractor options.)
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed this in my initial review of #2536. Also add a unit test to prevent us from making this mistake again.
Merge / deployment checklist