Feature flag: diff_informed_queries - #2551
Merged
cklin merged 1 commit intoOct 21, 2024
Merged
cklin merged 1 commit into
cklin merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
angelapwen
reviewed
Oct 18, 2024
Comment thread
src/feature-flags.ts
| defaultValue: false, | ||
| envVar: "CODEQL_ACTION_DIFF_INFORMED_QUERIES", | ||
| minimumVersion: undefined, | ||
| toolsFeature: ToolsFeature.DatabaseInterpretResultsSupportsSarifRunProperty, |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Just checking — is this because the same CLI version that supports DatabaseInterpretResultsSupportsSarifRunProperty also supports DiffInformedQueries?
Usually we have a separate entry in https://github.com/github/codeql-action/blob/main/src/tools-features.ts 😄
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Okay, I see Requires CodeQL CLI feature databaseInterpretResultsSupportsSarifRunProperty (since 2.19.0) in our internal issue so approving 😸
Sorry, something went wrong.
angelapwen
approved these changes
Oct 18, 2024
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Sorry, something went wrong.
This was referenced Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a feature flag for future use.
Merge / deployment checklist