FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add permissions to pr-checks workflow by jsoref · Pull Request #2555 · github/codeql-action · GitHub

/ codeql-action Public

Add permissions to pr-checks workflow - #2555

Merged
henrymercer merged 1 commit into
github:mainfrom
jsoref:fix-pr-check-permissions
Oct 21, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Add permissions to pr-checks workflow#2555
henrymercer merged 1 commit into
github:mainfrom
jsoref:fix-pr-check-permissions

Conversation

jsoref commented Oct 20, 2024

Copy link
Copy Markdown
Contributor

Without this, I get: https://github.com/check-spelling-sandbox/github-codeql-action/actions/runs/11429827970/job/31796641932

Run github/codeql-action/upload-sarif@v3
Warning: Resource not accessible by integration
Uploading results
  Processing sarif files: ["eslint.sarif"]
  Validating eslint.sarif
  Combining SARIF files using the CodeQL CLI
  Adding fingerprints to SARIF file. See https://docs.github.com/en/enterprise-cloud@latest/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning#providing-data-to-track-code-scanning-alerts-across-runs for more information.
  Uploading results
  Warning: Resource not accessible by integration
  Error: Resource not accessible by integration
  Warning: Resource not accessible by integration

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

jsoref requested a review from a team as a code owner October 20, 2024 22:14
NlightNFotis reviewed Oct 21, 2024
View reviewed changes

NlightNFotis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Would like someone else to have a look at this before we merge this.

henrymercer approved these changes Oct 21, 2024
View reviewed changes

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thank you for the fix!

henrymercer merged commit 165a22e into github:main Oct 21, 2024
jsoref deleted the fix-pr-check-permissions branch October 21, 2024 13:24
This was referenced Oct 22, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

NlightNFotis NlightNFotis approved these changes
henrymercer henrymercer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL