Add Feature.CppBuildModeNone - #2565
Merged
calumgrant merged 3 commits intoOct 23, 2024
Merged
calumgrant merged 3 commits into
calumgrant merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
calumgrant
force-pushed
the
calumgrant/bmn-ff
branch
from
c372418 to
48fd9d7
Compare
October 23, 2024 11:48
calumgrant
marked this pull request as ready for review
October 23, 2024 12:11
NlightNFotis
approved these changes
Oct 23, 2024
henrymercer
reviewed
Oct 23, 2024
Comment thread
src/feature-flags.ts
Comment on lines
+53
to
+54
| CppBuildModeNoneDisabled = "cpp_build_mode_none_disabled", | ||
| CppBuildModeNoneEnabled = "cpp_build_mode_none", |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Hey @calumgrant, sorry that this wasn't clear from the instructions. You only need to specify cpp_build_mode_none here — the API is responsible for combining the codeql_action_cpp_build_mode_none and codeql_action_cpp_build_mode_none_disabled feature flags to determine enablement. Hopefully this simplifies things a bit.
Sorry, something went wrong.
3 tasks
This was referenced Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/github/codeql-core/issues/4624
Merge / deployment checklist