Tolerate other GitHub variants when retrieving feature flags from GitHub API - #2567
Merged
NlightNFotis merged 3 commits intoOct 25, 2024
Merged
NlightNFotis merged 3 commits into
NlightNFotis merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
aeisenberg
previously approved these changes
Oct 24, 2024
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice. I didn't realize it was so easy. This looks like the right fix.
Before merging, can you do a quick check throughout the code to see if there's any other place we're missing GHE_DOTCOM?
Sorry, something went wrong.
henrymercer
previously approved these changes
Oct 25, 2024
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks Fotis!
Sorry, something went wrong.
NlightNFotis
dismissed stale reviews from henrymercer and aeisenberg
via
20d41c3
October 25, 2024 16:02
…uesting feature flags
NlightNFotis
force-pushed
the
NlightNFotis/feature_flag_fix
branch
from
20d41c3 to
6511785
Compare
October 25, 2024 16:05
henrymercer
reviewed
Oct 25, 2024
Comment thread
src/feature-flags.test.ts
Outdated
Co-authored-by: Henry Mercer <henrymercer@github.com>
NlightNFotis
force-pushed
the
NlightNFotis/feature_flag_fix
branch
from
e4e89f5 to
fddb49d
Compare
October 25, 2024 16:20
henrymercer
approved these changes
Oct 25, 2024
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for adding the test!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the capability to the GitHub API handler to tolerate other GitHub variants when retrieving feature flags.
Merge / deployment checklist