Improve robustness of extracting the bundle tag name - #2570
Merged
dbartol merged 2 commits intoOct 28, 2024
Merged
dbartol merged 2 commits into
dbartol merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
dbartol
approved these changes
Oct 28, 2024
dbartol
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This was referenced Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we'd extract the wrong tag for a tools URL like https://github.com/org/codeql-bundle-testing/releases/download/codeql-bundle-v2.19.0/codeql-bundle-linux64.tar.zst. This approach fixes that case while avoiding assuming too much about the structure of the tools URL.
Merge / deployment checklist