Download Zstandard bundles on GHES too by default - #2573
Merged
henrymercer merged 3 commits intoNov 1, 2024
Merged
henrymercer merged 3 commits into
henrymercer merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Data shows it is unneeded
aeisenberg
approved these changes
Nov 1, 2024
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
With this PR, users will no longer be able to control if they use zstd or tar. I think that's fine since it is not relevant for them if everything works anyway.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Yeah agreed. Customers can still specify a tools URL if they want to use gzip or zstd. In general I think we want to have flexibility to change the default way the tools are downloaded and installed, e.g. so we can move to per-language bundles. |
Sorry, something went wrong.
This was referenced Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're seeing an average 2x speed up by using bundles compressed using Zstandard. Now that this feature has stabilised, this PR rolls it out to GHES, cleans up the feature flags, and removes a mechanism to fall back to gzip that has not been needed.
Merge / deployment checklist