FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Minor cleanup by jsoref · Pull Request #2580 · github/codeql-action · GitHub

/ codeql-action Public

Minor cleanup - #2580

Merged
aeisenberg merged 6 commits into
github:mainfrom
jsoref:minor-cleanup
Nov 6, 2024
ConversationCommits (6)ChecksFiles changed
Merged

Minor cleanup#2580
aeisenberg merged 6 commits into
github:mainfrom
jsoref:minor-cleanup

Conversation

jsoref commented Nov 6, 2024 •
edited by aeisenberg
Loading

Copy link
Copy Markdown
Contributor

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

spelling: in case
16e8ccc 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref requested a review from a team as a code owner November 6, 2024 06:17
jsoref mentioned this pull request Nov 6, 2024
Closed
3 tasks
jsoref added 5 commits November 6, 2024 06:43
spelling: macos
756aa64 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Strip trailing whitespace generated by ruamel-yaml
d5e7384
Give expected-queries-runs permissions
1e6d67b
Fix publish-immutable-action version
688ea53
Conditionally clear runner cache
3b7b85f 
This allows runners that don't have the cache to run these workflows.
aeisenberg reviewed Nov 6, 2024
View reviewed changes
Comment thread .github/workflows/expected-queries-runs.yml
Comment on lines +25 to +27
permissions:
contents: read
security-events: write

aeisenberg Nov 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is this necessary? CODEQL_ACTION_TEST_MODE should prevent the sarif from being uploaded.

Maybe this is all that is necessary (in order to check out the repo):

    permissions:
      contents: read

jsoref Nov 6, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Expected Queries Tests
This run of the CodeQL Action does not have permission to access Code Scanning API endpoints. As a result, it will not be opted into any experimental features. This could be because the Action is running on a pull request from a fork. If not, please ensure the Action has the 'security-events: write' permission. Details: Resource not accessible by integration
https://github.com/check-spelling-sandbox/github-codeql-action/actions/runs/11648653925

aeisenberg Nov 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is probably something about running in a fork. It's not a problem to leave it in.

Comment thread pr-checks/checks/zstd-bundle-streaming.yml
const path = require('path');
const codeqlPath = path.join(process.env['RUNNER_TOOL_CACHE'], 'CodeQL');
fs.rmdirSync(codeqlPath, { recursive: true });
if (codeqlPath !== undefined) {

aeisenberg Nov 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you explain why you need this? Is this because you are using a self-hosted runner somewhere?

jsoref Nov 6, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm using nektos/act which uses a custom image

jsoref Nov 6, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've also historically used self-hosted runners.

aeisenberg Nov 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That's fine.

aeisenberg approved these changes Nov 6, 2024
View reviewed changes

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the contribution.

Comment thread pr-checks/checks/zstd-bundle-streaming.yml
const path = require('path');
const codeqlPath = path.join(process.env['RUNNER_TOOL_CACHE'], 'CodeQL');
fs.rmdirSync(codeqlPath, { recursive: true });
if (codeqlPath !== undefined) {

aeisenberg Nov 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That's fine.

Comment thread .github/workflows/expected-queries-runs.yml
Comment on lines +25 to +27
permissions:
contents: read
security-events: write

aeisenberg Nov 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is probably something about running in a fork. It's not a problem to leave it in.

aeisenberg merged commit 5ac2ddd into github:main Nov 6, 2024
jsoref deleted the minor-cleanup branch November 7, 2024 01:01
This was referenced Nov 8, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aeisenberg aeisenberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL