Temporarily include the Actions extractor with the Action - #2582
Merged
dbartol merged 5 commits intoNov 8, 2024
Merged
dbartol merged 5 commits into
dbartol merged 5 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
added 5 commits
November 7, 2024 14:31
This could cause an error with older CLI versions because the extractor uses a new property in its `codeql-extractor.yml`.
Copy link
Copy Markdown
Contributor
|
This looks reasonable. Can you share a link to the run in the test repo? |
Sorry, something went wrong.
henrymercer
approved these changes
Nov 8, 2024
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This seems like a good approach to me given the size of the Actions extractor.
The internal test run looks good, so approving.
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Successful run in semmle-code: https://github.com/github/semmle-code/actions/runs/11731165575/job/32680646659 |
Sorry, something went wrong.
dbartol
marked this pull request as ready for review
November 8, 2024 16:13
dbartol
enabled auto-merge
November 8, 2024 16:13
This was referenced Nov 12, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR embeds the new experimental actions extractor to the CodeQL Action repo itself, and updates the init action to add that directory to --search-path if the actions language is enabled.
This is a hack to make the actions extractor available without it actually being in the bundle. This is needed for some internal testing over the next couple of weeks, after which the extractor will be in the bundle and we can remove this hack.
The extractor sources embedded here are just the current version copied directly from github/codeql.
I've already verified that this works correctly on a test repo with Advanced Setup.