FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Dependency caching: small output improvements by mbg · Pull Request #2597 · github/codeql-action · GitHub

Dependency caching: small output improvements - #2597

Merged
mbg merged 2 commits into
mainfrom
mbg/caching/output-improvements
Nov 14, 2024
Merged

Dependency caching: small output improvements#2597
mbg merged 2 commits into
mainfrom
mbg/caching/output-improvements

Conversation

mbg commented Nov 12, 2024

Copy link
Copy Markdown
Member

This PR makes two small changes related to dependency caching to improve the Action's output during normal operation:

  • We intercept ReserveCacheError errors when saving caches, since these are expected when a cache already exists for a given cache key. We log a message indicating this instead of propagating the error itself.
  • We allow warnings from tryGetFolderBytes to be suppressed, which would otherwise result in check annotations for a workflow run. This occurs during normal operation, since we try to calculate the cache size for all folders that may need to be cached for a given language, whether they exist or not. If they do not exist, that's not a problem for us.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

mbg self-assigned this Nov 12, 2024
mbg requested a review from a team as a code owner November 12, 2024 15:20

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice.

mbg merged commit 3ab67a2 into main Nov 14, 2024
mbg deleted the mbg/caching/output-improvements branch November 14, 2024 11:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL