Fix DiffThunkRange access - #2620
Merged
cklin merged 1 commit intoDec 2, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
src/analyze.ts
Fixed
This commit fixes lingering array index access that I missed when I converted getPullRequestEditedDiffRanges() results from tuples to DiffThunkRange objects.
cklin
force-pushed
the
cklin/DiffThunkRange-fix
branch
from
8914b01 to
2eea97e
Compare
November 21, 2024 21:49
cklin
marked this pull request as ready for review
November 21, 2024 22:05
angelapwen
approved these changes
Nov 22, 2024
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for catching this! 🧹
Sorry, something went wrong.
This was referenced Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes lingering array index access that I missed when I converted getPullRequestEditedDiffRanges() results from tuples to DiffThunkRange objects.
Merge / deployment checklist