Extract git-utils.ts - #2639
Merged
cklin merged 3 commits intoDec 10, 2024
Merged
Extract git-utils.ts#2639cklin merged 3 commits into
cklin merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cklin
marked this pull request as ready for review
December 9, 2024 23:03
henrymercer
previously approved these changes
Dec 10, 2024
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for this! Are there any other changes beyond reorganizing the files? I didn't see anything obvious, but wanted to double check.
Sorry, something went wrong.
Base automatically changed from
cklin/diff-informed-graph-fetching-tweak
to
main
December 10, 2024 16:42
Copy link
Copy Markdown
Contributor
Author
This is a pure refactoring PR, and there are no changes beyond reorganizing the files. |
Sorry, something went wrong.
cklin
force-pushed
the
cklin/extract-git-utils
branch
from
9bdb53b to
300d251
Compare
December 10, 2024 16:46
Comment thread
src/git-utils.ts
| // the GITHUB_REF as that is a protected variable and cannot be overwritten. | ||
| let refEnv: string; | ||
| try { | ||
| refEnv = getRequiredEnvParam("GITHUB_REF"); |
Check warning
Code scanning / CodeQL
Some environment variables may not exist in default setup workflows
henrymercer
approved these changes
Dec 10, 2024
This was referenced Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactoring PR that addresses the TODO item left from #2559.
Merge / deployment checklist