Start Proxy: Make the post step more robust to errors - #2643
Merged
marcogario merged 3 commits intoDec 11, 2024
Merged
marcogario merged 3 commits into
marcogario merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
src/start-proxy-action-post.ts
Fixed
Comment thread
src/start-proxy-action-post.ts
Fixed
Comment thread
src/start-proxy-action-post.ts
Fixed
marcogario
force-pushed
the
marcogario/robustify_start_proxy_post
branch
from
d0a1f42 to
47dd68e
Compare
December 11, 2024 15:12
marcogario
marked this pull request as ready for review
December 11, 2024 15:21
aibaars
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The post step of the start-proxy action tries to kill the proxy process and, when run in debug mode, uploads a log file as artifact. This PR makes failures in either of those operations non-fatal. Moreover, it extends the manifest for the action to include the github token that is required to upload the artifact itself.
This action is used internally, so I don't think a changelog entry is needed, but happy to copy a summary of ^.
Merge / deployment checklist