Use an app token for triggering a release - #2644
aeisenberg merged 1 commit into
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1).github/workflows/post-release-mergeback.yml:166
- The new token generation step should be tested to ensure it works as expected. Consider adding a test workflow to validate the token creation process.
uses: actions/create-github-app-token@5d869da34e18e7287c1daad50e0b8ea0f506ce69
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Sorry, something went wrong.
henrymercer
left a comment
There was a problem hiding this comment.
The indentation doesn't look quite right, but otherwise this looks good!
Sorry, something went wrong.
We need to do this because using a default token will not recursively trigger a new workflow run.
|
Fixed the indentation. After merging, I will do a release to see if this fixes the problem. |
Sorry, something went wrong.
NlightNFotis
left a comment
There was a problem hiding this comment.
Code-wise, this looks good.
The only question is whether the permissions are adequate for performing the release, but I guess we won't know until we try it.
Sorry, something went wrong.
I believe so. We need contents: write for this to work. And the app provides it. |
Sorry, something went wrong.
We need to do this because using a default token will not recursively trigger a new workflow run.
The only way to test this is to merge to main and do a release.
Merge / deployment checklist