Remove redundant version checks - #2696
Merged
henrymercer merged 2 commits intoJan 16, 2025
Merged
henrymercer merged 2 commits into
henrymercer merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Remove version checks that always return true given the new minimum version of CodeQL.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot reviewed 52 out of 67 changed files in this pull request and generated no comments.
Files not reviewed (15)- .github/workflows/__config-export.yml: Evaluated as low risk
- .github/workflows/__cpp-deptrace-enabled.yml: Evaluated as low risk
- .github/workflows/__cpp-deptrace-enabled-on-macos.yml: Evaluated as low risk
- .github/workflows/__cpp-deptrace-disabled.yml: Evaluated as low risk
- .github/workflows/__config-input.yml: Evaluated as low risk
- .github/workflows/__build-mode-none.yml: Evaluated as low risk
- .github/workflows/__build-mode-rollback.yml: Evaluated as low risk
- .github/workflows/__cleanup-db-cluster-dir.yml: Evaluated as low risk
- .github/workflows/__autobuild-action.yml: Evaluated as low risk
- .github/workflows/__autobuild-direct-tracing-with-working-dir.yml: Evaluated as low risk
- .github/workflows/__build-mode-autobuild.yml: Evaluated as low risk
- .github/workflows/__analyze-ref-input.yml: Evaluated as low risk
- .github/workflows/__extractor-ram-threads.yml: Evaluated as low risk
- .github/workflows/__extract-direct-to-toolcache.yml: Evaluated as low risk
- .github/workflows/__autobuild-direct-tracing.yml: Evaluated as low risk
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Sorry, something went wrong.
angelapwen
approved these changes
Jan 15, 2025
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Sorry, something went wrong.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
+1 more reviewerAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete redundant code after the deprecation of CodeQL v2.15.4 and earlier.
Merge / deployment checklist