getDiffRanges: better fallback for absent patch - #2699
Merged
cklin merged 2 commits intoJan 16, 2025
Merged
cklin merged 2 commits into
cklin merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Sorry, something went wrong.
henrymercer
previously approved these changes
Jan 16, 2025
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Makes sense 👍
Sorry, something went wrong.
angelapwen
approved these changes
Jan 16, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was pointed out to me in a meeting today that we do not necessarily need to fall back to full analysis even if we cannot obtain the patch for a specific file (for example, if the diff is too large). Instead, we can continue with diff-informed analysis, using an (already supported) special diff range to cover that entire file.
This PR implements that improvement.
Merge / deployment checklist