Temporarily disable uploading debug artifacts - #2712
Merged
angelapwen merged 1 commit intoJan 22, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Sorry, something went wrong.
angelapwen
force-pushed
the
angelapwen/stop-debug-artifacts
branch
from
4c26822 to
519de26
Compare
January 22, 2025 18:35
aeisenberg
approved these changes
Jan 22, 2025
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, assuming that eslint doesn't complain about unreachable code.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing PR checks for debug artifacts will be failing and this is expected.
I have temporarily removed them from branch protection rules. We should re-add them when we restore functionality.
Merge / deployment checklist