Kotlin: The 2.20.3 release supports Kotlin 2.1.10. - #2744
Merged
igfoo merged 3 commits intoJan 29, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)src/init-action.ts:547
- The Kotlin version limit is set to 2.1.20, whereas the title suggests supporting Kotlin 2.1.10. Please confirm which version is correct to avoid confusion or unintended behavior.
core.exportVariable(kotlinLimitVar, "2.1.20");
src/init-action.ts:543
- This new logic to set a Kotlin version limit depending on CodeQL versions is untested. Please add automated tests verifying that the environment variable is correctly set for CodeQL versions between 2.20.3 and 2.20.4.
if ( (await codeQlVersionAtLeast(codeql, "2.20.3")) && !(await codeQlVersionAtLeast(codeql, "2.20.4")) ) {
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Sorry, something went wrong.
igfoo
force-pushed
the
igfoo/kot2.1.10
branch
from
208d567 to
3879c57
Compare
January 29, 2025 13:08
henrymercer
approved these changes
Jan 29, 2025
8 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist