Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The number of GB is at most 2, and can be tiny. MB gives a more comprehensible range of values.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
PR Overview
This PR changes the disk space warning message to display available disk space in MB instead of GB for better clarity with small amounts.
- Updated disk space warning message in lib/util.js
- Updated disk space warning message in src/util.ts
Reviewed Changes
| File | Description |
|---|---|
| lib/util.js | Replaced GB values with MB in the disk usage warning message. |
| src/util.ts | Replaced GB values with MB in the disk usage warning message. |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)lib/util.js:828
- The check still uses a threshold of 2 * gbInBytes while the message shows disk space in MB. For consistency, consider aligning the threshold with the displayed unit or adding a comment that explains the difference.
if (diskUsage.free < 2 * gbInBytes) {
src/util.ts:1059
- The disk space threshold is still based on GB units, whereas the warning message now displays MB. Consider aligning the units for consistency if that is your intention.
if (diskUsage.free < 2 * gbInBytes) {
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Sorry, something went wrong.
henrymercer
approved these changes
Feb 26, 2025
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Makes sense, thank you!
Sorry, something went wrong.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The number of GB is at most 2, and can be tiny. MB gives a more comprehensible range of values.
Merge / deployment checklist