PR Overview

This PR refines error handling around downloading and extracting the CodeQL CLI and introduces a new error category for temporary directory issues.

• Updates error rethrowing in both JavaScript and TypeScript implementations to conditionally use a ConfigurationError.
• Adds a new error category "CouldNotCreateTempDir" in both the JS and TS CLI error modules.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

lib/codeql.js:136

• Consider using a helper function or preserving the original error (including its prototype and stack trace) when rethrowing. This can improve debuggability by retaining more context from the original error.

const ErrorClass = e instanceof util.ConfigurationError || (e instanceof Error && e.message.includes("ENOSPC")) // out of disk space

src/codeql.ts:380

• Similar to the JS version, consider preserving the original error context by wrapping or logging the actual error object when rethrowing it. Maintaining the original error's details can help with future debugging.

const ErrorClass = e instanceof util.ConfigurationError || (e instanceof Error && e.message.includes("ENOSPC")) // out of disk space

lib/cli-errors.js:113

• The new error category 'CouldNotCreateTempDir' appears clear; please ensure downstream error handling also recognizes and properly handles this category.

CliConfigErrorCategory["CouldNotCreateTempDir"] = "CouldNotCreateTempDir";

src/cli-errors.ts:122

• Ensure that the error messages or handling logic associated with 'CouldNotCreateTempDir' are consistent with its usage in the JS version.

CouldNotCreateTempDir = "CouldNotCreateTempDir",

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more