Use embedded actions extractor only for old CLI versions - #2788
dbartol merged 2 commits into
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
PR Overview
This PR updates the logic to use the embedded actions extractor only for CLI versions prior to 2.20.6.
- Updates conditional logic based on the CodeQL version
- Includes detailed inline comments explaining the rationale for maintaining the embedded extractor for older versions
Reviewed Changes
| File | Description |
|---|---|
| src/codeql.ts | Modified conditional check to use the embedded extractor only for pre-2.20.6 versions |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Sorry, something went wrong.
angelapwen
left a comment
There was a problem hiding this comment.
Makes sense to me 👍 do we want to add a changenote for this or are we skipping it because it's experimental?
Sorry, something went wrong.
For this change, there should be no user-visible impact, so I'm skipping the change note. When we do finally remove the embedded extractor entirely, I'll add a change note, although we don't expect any users to actually notice the breaking change. |
Sorry, something went wrong.
|
Sounds good to me!! 🚢 |
Sorry, something went wrong.
When trying to remove the embedded actions extractor, we discovered that the extractor in the actual CLI download is missing the execute bit on its scripts. That's fixed in 2.20.6, so I've changed the Action to only use the embedded extractor for pre-2.20.6 versions.
Merge / deployment checklist