Set checkPresence in diff-range data extension - #2843
Merged
cklin merged 1 commit intoApr 7, 2025
Merged
cklin merged 1 commit into
cklin merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This commit updates the diff-range data extension to use the new checkPresence field being introduced in CodeQL CLI 2.21.0, so that diff-informed analysis no longer fails when a query pack does not have the restrictAlertsTo extensible predicate.
cklin
force-pushed
the
cklin/diff-informed-compat
branch
from
5761979 to
94102d9
Compare
April 4, 2025 15:41
cklin
marked this pull request as ready for review
April 4, 2025 17:08
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the diff-range data extension to support the new checkPresence field from CodeQL CLI 2.21.0, ensuring that diff-informed analysis works correctly when a query pack lacks the restrictAlertsTo extensible predicate.
- Update the minimumVersion for DiffInformedQueries in feature flag configurations (TypeScript & JavaScript) to "2.21.0".
- Add the checkPresence property (set to false) in the corresponding analyze extensions in both TypeScript and JavaScript files.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/feature-flags.ts | Updated minimumVersion to "2.21.0" for DiffInformedQueries feature. |
| src/analyze.ts | Added checkPresence: false for the query pack extensions. |
| lib/feature-flags.js | Updated minimumVersion to "2.21.0" for DiffInformedQueries feature. |
| lib/analyze.js | Added checkPresence: false for the query pack extensions. |
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Sorry, something went wrong.
aeisenberg
approved these changes
Apr 7, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the diff-range data extension to use the new checkPresence field being introduced in CodeQL CLI 2.21.0, so that diff-informed analysis no longer fails when a query pack does not have the restrictAlertsTo extensible predicate.
Merge / deployment checklist