move use of input variables into env vars - #2857
Merged
nickfyson merged 1 commit intoApr 9, 2025
Merged
nickfyson merged 1 commit into
nickfyson merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors GitHub Actions workflows by moving direct input variable usage into environment variables for improved readability and maintainability.
- In the release-branches action, inputs for "major_version" and "latest_tag" are now set as environment variables.
- In the prepare-test action, inputs for "version" and "use-all-platform-bundle" are similarly moved into environment variables and used in conditional checks.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/actions/release-branches/action.yml | Introduces env vars for MAJOR_VERSION and LATEST_TAG, and updates command args |
| .github/actions/prepare-test/action.yml | Adds env vars for VERSION and USE_ALL_PLATFORM_BUNDLE, and updates comparison logic |
Sorry, something went wrong.
NlightNFotis
approved these changes
Apr 9, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves a number of uses of ${{ inputs.foo_bar }} into environment variables for the step in question.
Merge / deployment checklist