| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
This PR enables configuring the number of CodeQL threads via an environment variable.
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks for your PR. I don't think this is harmful or could break anything, but it seems a bit redundant.
Can you try this alternate approach?
In the init/actions.yml file add default: "${{ env.CODEQL_THREADS }}" to the threads input. This should be sufficient.
Sorry, something went wrong.
Yep I can give this a shot. My initial change was just trying to match up the way the ram variable was treated |
Sorry, something went wrong.
Great. Let me know if this works for you. Now that I'm engaged, I'll be able to respond more quickly to this PR. |
Sorry, something went wrong.
|
@aeisenberg lmk what you think 👍 |
Sorry, something went wrong.
There was a problem hiding this comment.
This looks right to me.
Sorry, something went wrong.
|
@aeisenberg ah I don't think you can use env variable expressions in inputs Error: /Users/runner/work/codeql-action/codeql-action/./../action/init/action.yml (Line: 118, Col: 14): Unrecognized named-value: 'env'. Located at position 1 within expression: env.CODEQL_THREADS |
Sorry, something went wrong.
This reverts commit df7d681.
|
Oh...that's really unfortunate. Apologies for the confusion. I'm asking internally what's going on since this is a pattern that's being used elsewhere. |
Sorry, something went wrong.
Most of those examples commented out the default field with a # though. I'm not sure why the env context is not allowed, perhaps it is not available until a workflow starts to "run". |
Sorry, something went wrong.
|
Thanks for the contribution @austinpray-mixpanel! Could you follow the instructions in https://github.com/github/codeql-action/blob/main/CONTRIBUTING.md#common-tasks to rebuild the project? |
Sorry, something went wrong.
|
Thank you all! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
closes #2890
Merge / deployment checklist