FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update README.md by kaushganguly · Pull Request #2934 · github/codeql-action · GitHub

Update README.md - #2934

Merged
mbg merged 2 commits into
github:mainfrom
kaushganguly:patch-1
Jun 16, 2025
Merged

Update README.md#2934
mbg merged 2 commits into
github:mainfrom
kaushganguly:patch-1

Conversation

Copy link
Copy Markdown
Contributor

Build mode none is in public preview for C/C++. Readme updated.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

Build mode `none` is in public preview for C/C++. Readme updated.
Copilot AI review requested due to automatic review settings June 16, 2025 04:43
kaushganguly requested a review from a team as a code owner June 16, 2025 04:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull Request Overview

This PR updates the documentation for the none build mode to reflect that it is now in public preview for C/C++.

  • Clarifies that C/C++ support is in public preview rather than unsupported.
  • Adjusts the list of languages for which none is not yet supported.
Comments suppressed due to low confidence (1)

README.md:58

  • [nitpick] Consider adding a comma before "and" for clearer separation (e.g., ... Kotlin, and it is in public preview for C/C++.) and removing the backticks around "public preview" since it's not a build-mode flag.
+ `none` build mode is also simpler to set up and is slightly faster to run, but there is a possibility that some alerts will be missed. This may happen if your repository does any code generation during compilation or if there are any dependencies downloaded from registries that the workflow does not have access to. `none` is not yet supported by Swift, Go, or Kotlin and it is in `public preview` for C/C++.

mbg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi @kgangulyvibe 👋🏻

Thanks for noticing this and preparing a PR to improve it! I'd be happy to merge this with the two minor changes I proposed.

Comment thread README.md Outdated
Co-authored-by: Michael B. Gale <mbg@github.com>

kaushganguly left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Updated!

mbg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you very much!

mbg enabled auto-merge June 16, 2025 11:00
mbg merged commit ece6bb6 into github:main Jun 16, 2025
github-actions Bot mentioned this pull request Jun 27, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL